HID: sony: validate HID output report details
authorKees Cook <keescook@chromium.org>
Wed, 11 Sep 2013 19:56:52 +0000 (21:56 +0200)
committerJiri Kosina <jkosina@suse.cz>
Fri, 13 Sep 2013 13:12:12 +0000 (15:12 +0200)
commit9446edb9a1740989cf6c20daf7510fb9a23be14a
tree9a58264ba2bcac1c67813ac32611870c552e9101
parent78214e81a1bf43740ce89bb5efda78eac2f8ef83
HID: sony: validate HID output report details

This driver must validate the availability of the HID output report and
its size before it can write LED states via buzz_set_leds(). This stops
a heap overflow that is possible if a device provides a malicious HID
output report:

[  108.171280] usb 1-1: New USB device found, idVendor=054c, idProduct=0002
...
[  117.507877] BUG kmalloc-192 (Not tainted): Redzone overwritten

CVE-2013-2890

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org #3.11
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-sony.c