pptp: dst_release sk_dst_cache in pptp_sock_destruct
authorXin Long <lucien.xin@gmail.com>
Wed, 13 Mar 2019 09:00:48 +0000 (17:00 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Mar 2019 21:22:49 +0000 (14:22 -0700)
commit9417d81f4f8adfe20a12dd1fadf73a618cbd945d
treee5909be0f6b3404f4a85c7bc184aa21b7dc32c45
parent63b6c974c24cc6a56cd1c17609d8d218dcff999c
pptp: dst_release sk_dst_cache in pptp_sock_destruct

sk_setup_caps() is called to set sk->sk_dst_cache in pptp_connect,
so we have to dst_release(sk->sk_dst_cache) in pptp_sock_destruct,
otherwise, the dst refcnt will leak.

It can be reproduced by this syz log:

  r1 = socket$pptp(0x18, 0x1, 0x2)
  bind$pptp(r1, &(0x7f0000000100)={0x18, 0x2, {0x0, @local}}, 0x1e)
  connect$pptp(r1, &(0x7f0000000000)={0x18, 0x2, {0x3, @remote}}, 0x1e)

Consecutive dmesg warnings will occur:

  unregister_netdevice: waiting for lo to become free. Usage count = 1

v1->v2:
  - use rcu_dereference_protected() instead of rcu_dereference_check(),
    as suggested by Eric.

Fixes: 00959ade36ac ("PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol)")
Reported-by: Xiumei Mu <xmu@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ppp/pptp.c