drm/plane-helper: Skip prepare_fb/cleanup_fb when newfb==oldfb
authorMatt Roper <matthew.d.roper@intel.com>
Mon, 19 Jan 2015 16:31:49 +0000 (08:31 -0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 26 Jan 2015 07:21:56 +0000 (08:21 +0100)
commit92890583627ee2a0518e55b063fcff86826fef96
tree1257552efa48a4d3a7622fe8aeac0da0f8fee277
parent281d1bbd34b734e4f22b30b6f3b673dda46a7470
drm/plane-helper: Skip prepare_fb/cleanup_fb when newfb==oldfb

When commiting a plane update where the framebuffer doesn't change, we
can skip the prepare_fb/cleanup_fb steps.  This also allows us to avoid
an unnecessary vblank wait at the end of the operation when we're just
moving a plane and not changing its image (e.g., for a cursor).

At the moment, i915 is the only upstream driver using the transitional
plane helpers, and thus the only driver affected by this change.

Note that this replicates a corresponding change in the atomic helpers
implemented in

commit ab58e3384b9f9863bfd029b458ff337d381bf6d2
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Mon Nov 24 20:42:42 2014 +0100

    drm/atomic-helper: Skip vblank waits for unchanged fbs

Reported-by: Jeremiah Mahler <jmmahler@gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88540
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Tested-by: Tested-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_plane_helper.c