postgresql: clean up CFLAGS
authorSebastian Kemper <sebastian_ml@gmx.net>
Mon, 19 Mar 2018 22:38:45 +0000 (23:38 +0100)
committerSebastian Kemper <sebastian_ml@gmx.net>
Mon, 19 Mar 2018 22:38:48 +0000 (23:38 +0100)
commit8e9ad7bb5117edea4df08cd9a2de62685103a4b3
tree2646918a9c14a194a58b484499f4af9bf88ee0a3
parent2ab50dff2409f32f6dcd1d6152704de6969fa633
postgresql: clean up CFLAGS

- The extra include is removed; the postgresql build system adds this
  include by itself.

- '-lpthread' is removed; the postgresql build system is able to detect
  how to access pthread features by itself.

- '$(FPIC)' is removed; adding this to CFLAGS is not recommendable:

  a) The postgresql build system adds its own PIC flag behind OpenWrt's
  CFLAGS when compiling shared objects, overriding OpenWrt's setting.
  b) Forcing applications into PIC mode will just slow them down.
  c) This leads to build failures on aarch64:

    access/transam/commit_ts.o: In function `CommitTsPagePrecedes':
    commit_ts.c:(.text+0x14): relocation truncated to fit: R_AARCH64_LD64_GOTPAGE_LO15 against symbol `TransactionIdPrecedes' defined in .text section in access/transam/transam.o
    commit_ts.c:(.text+0x14): warning: Too many GOT entries for -fpic, please recompile with -fPIC
    /var/lib/buildbot/slaves/dave-builder/aarch64_generic/build/sdk/staging_dir/toolchain-aarch64_generic_gcc-7.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/7.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: final link failed: Symbol needs debug section which does not exist
    collect2: error: ld returned 1 exit status

Signed-off-by: Sebastian Kemper <sebastian_ml@gmx.net>
libs/postgresql/Makefile