pipe: Remove assertion from pipe_poll()
authorDavid Howells <dhowells@redhat.com>
Thu, 5 Dec 2019 22:30:30 +0000 (22:30 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 5 Dec 2019 23:33:50 +0000 (15:33 -0800)
commit8c7b8c34ae952cc062c12d7db9ee2f298c09dca4
tree2b51d3882e2b1a9126e37725a6e1525f5a763e00
parent3c0edea9b29f9be6c093f236f762202b30ac9431
pipe: Remove assertion from pipe_poll()

An assertion check was added to pipe_poll() to make sure that the ring
occupancy isn't seen to overflow the ring size.  However, since no locks
are held when the three values are read, it is possible for F_SETPIPE_SZ
to intervene and muck up the calculation, thereby causing the oops.

Fix this by simply removing the assertion and accepting that the
calculation might be approximate.

Note that the previous code also had a similar issue, though there was
no assertion check, since the occupancy counter and the ring size were
not read with a lock held, so it's possible that the poll check might
have malfunctioned then too.

Also wake up all the waiters so that they can reissue their checks if
there was a competing read or write.

Fixes: 8cefc107ca54 ("pipe: Use head and tail pointers for the ring, not cursor and length")
Reported-by: syzbot+d37abaade33a934f16f2@syzkaller.appspotmail.com
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/pipe.c