elv_iosched_store(): fix strstrip() misuse
authorKOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Fri, 9 Oct 2009 06:48:08 +0000 (08:48 +0200)
committerJens Axboe <jens.axboe@oracle.com>
Fri, 9 Oct 2009 06:48:08 +0000 (08:48 +0200)
commit8c279598585e4992a41016bb973993ed15888cb3
tree47da450c888cf5b63790e37e4b7640acbc3570a2
parent355b659c87432a4e76160640625c47fcf9174e8d
elv_iosched_store(): fix strstrip() misuse

elv_iosched_store() ignore the return value of strstrip().  It makes small
inconsistent behavior.

This patch fixes it.

 <before>
 ====================================
 # cd /sys/block/{blockdev}/queue

 case1:
 # echo "anticipatory" > scheduler
 # cat scheduler
 noop [anticipatory] deadline cfq

 case2:
 # echo "anticipatory " > scheduler
 # cat scheduler
 noop [anticipatory] deadline cfq

 case3:
 # echo " anticipatory" > scheduler
 bash: echo: write error: Invalid argument

 <after>
 ====================================
 # cd /sys/block/{blockdev}/queue

 case1:
 # echo "anticipatory" > scheduler
 # cat scheduler
 noop [anticipatory] deadline cfq

 case2:
 # echo "anticipatory " > scheduler
 # cat scheduler
 noop [anticipatory] deadline cfq

 case3:
 # echo " anticipatory" > scheduler
 noop [anticipatory] deadline cfq

Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
block/elevator.c