ovl: fix oopses in ovl_fill_super() failure paths
authorMiklos Szeredi <mszeredi@redhat.com>
Mon, 10 Sep 2018 09:43:29 +0000 (11:43 +0200)
committerMiklos Szeredi <mszeredi@redhat.com>
Mon, 10 Sep 2018 10:55:49 +0000 (12:55 +0200)
commit8c25741aaad8be6fbe51510e917c740e0059cf83
tree7f376965701e9e17bf83cea45fe0b62b94ae519c
parentb833a3660394876541d2513ce2736debc7c6797a
ovl: fix oopses in ovl_fill_super() failure paths

ovl_free_fs() dereferences ofs->workbasedir and ofs->upper_mnt in cases when
those might not have been initialized yet.

Fix the initialization order for these fields.

Reported-by: syzbot+c75f181dc8429d2eb887@syzkaller.appspotmail.com
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Cc: <stable@vger.kernel.org> # v4.15
Fixes: 95e6d4177cb7 ("ovl: grab reference to workbasedir early")
Fixes: a9075cdb467d ("ovl: factor out ovl_free_fs() helper")
fs/overlayfs/super.c