solos-pci: use permission-specific DEVICE_ATTR variants
authorJulia Lawall <julia.lawall@lip6.fr>
Sat, 29 Oct 2016 19:37:09 +0000 (21:37 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 31 Oct 2016 19:32:12 +0000 (15:32 -0400)
commit89d9123e8ee28cb380ce5532038e89fc19471a77
treeab28429ca0dd682799591474fe88c4b5fcd96ec0
parent63215705a6cc4481dde21b5343bb706837f273d9
solos-pci: use permission-specific DEVICE_ATTR variants

Use DEVICE_ATTR_RW for read-write attributes.  This simplifies the
source code, improves readbility, and reduces the chance of
inconsistencies.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@rw@
declarer name DEVICE_ATTR;
identifier x,x_show,x_store;
@@

DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store);

@script:ocaml@
x << rw.x;
x_show << rw.x_show;
x_store << rw.x_store;
@@

if not (x^"_show" = x_show && x^"_store" = x_store)
then Coccilib.include_match false

@@
declarer name DEVICE_ATTR_RW;
identifier rw.x,rw.x_show,rw.x_store;
@@

- DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store);
+ DEVICE_ATTR_RW(x);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/solos-pci.c