projects / project / bcm63xx / atf.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1761295) | patch
uart: 16550: Fix getc
authorNishanth Menon <nm@ti.com>
Tue, 10 Jan 2017 15:34:07 +0000 (09:34 -0600)
committerNishanth Menon <nm@ti.com>
Tue, 10 Jan 2017 15:36:44 +0000 (09:36 -0600)
commit861ac52a7e80c0399b6e543e7125a9c1e18a63f8
tree4d735faceb0449e4de072adc56e60e88d105a69ftree | snapshot
parent176129530e80491a789ea6402a18b65834c7fe54commit | diff
uart: 16550: Fix getc

tbz check for RDR status is to check for a bit being zero.
Unfortunately, we are using a mask rather than the bit position.

Further as per http://www.ti.com/lit/ds/symlink/pc16550d.pdf (page 17),
LSR register bit 0 is Data ready status (RDR), not bit position 2.

Update the same to match the specification.

Reported-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
drivers/ti/uart/aarch64/16550_console.S diff | blob | history
include/drivers/ti/uart/uart_16550.h diff | blob | history
Broadcom-s Trusted Firmware A