apparmor: enforce nullbyte at end of tag string
authorJann Horn <jannh@google.com>
Tue, 28 May 2019 15:32:26 +0000 (17:32 +0200)
committerJohn Johansen <john.johansen@canonical.com>
Tue, 18 Jun 2019 23:04:16 +0000 (16:04 -0700)
commit8404d7a674c49278607d19726e0acc0cae299357
treef78a44caa2a078b9325289d67d05993024aab15f
parent23375b13f98c5464c2b4d15f983cc062940f1f4e
apparmor: enforce nullbyte at end of tag string

A packed AppArmor policy contains null-terminated tag strings that are read
by unpack_nameX(). However, unpack_nameX() uses string functions on them
without ensuring that they are actually null-terminated, potentially
leading to out-of-bounds accesses.

Make sure that the tag string is null-terminated before passing it to
strcmp().

Cc: stable@vger.kernel.org
Fixes: 736ec752d95e ("AppArmor: policy routines for loading and unpacking policy")
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
security/apparmor/policy_unpack.c