projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9e4cc25) | patch
Input: twl4030 - fix unsafe macro definition
authorRui Teng <rui.teng@linux.vnet.ibm.com>
Tue, 26 Apr 2016 16:45:13 +0000 (09:45 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 29 Apr 2016 20:59:00 +0000 (13:59 -0700)
commit82ba0d8ba48df5442ff31ee6f62b594f062bc162
tree43097efd729bc829a33fa8c7170be52d3513b6e9tree | snapshot
parent9e4cc255e6e18418ddbeea447efa506bb43d57a2commit | diff
Input: twl4030 - fix unsafe macro definition

The bitwise shift operator has lower priority than plus operator. So the
values on macros should be enclosed in parentheses.

For example, "(1 << 4 + 1)" means "(1 << (4 + 1))", but it is not expected
by the macros.

And also fix other two coding style problems reported by
scripts/checkpatch.pl.

Signed-off-by: Rui Teng <rui.teng@linux.vnet.ibm.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/twl4030_keypad.c diff | blob | history
John Crispins staging tree