USB: sierra: fix urb and memory leak in resume error path
authorJohan Hovold <jhovold@gmail.com>
Mon, 26 May 2014 17:22:52 +0000 (19:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 May 2014 22:04:02 +0000 (15:04 -0700)
commit7fdd26a01eb7b6cb6855ff8f69ef4a720720dfcb
tree054f093409b73d8f0d1a14ce9ed08eabbf79c2f7
parent8452727de70f6ad850cd6d0aaa18b5d9050aa63b
USB: sierra: fix urb and memory leak in resume error path

Neither the transfer buffer or the urb itself were released in the
resume error path for delayed writes. Also on errors, the remainder of
the queue was not even processed, which leads to further urb and buffer
leaks.

The same error path also failed to balance the outstanding-urb counter,
something which results in degraded throughput or completely blocked
writes.

Fix this by releasing urb and buffer and balancing counters on errors,
and by always processing the whole queue even when submission of one urb
fails.

Fixes: e6929a9020ac ("USB: support for autosuspend in sierra while
online")

Cc: <stable@vger.kernel.org> # v2.6.32
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/sierra.c