projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f0654ba) | patch
ALSA: seq: Cover unsubscribe_port() in list_mutex
authorTakashi Iwai <tiwai@suse.de>
Fri, 12 Apr 2019 09:37:19 +0000 (11:37 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 12 Apr 2019 10:50:10 +0000 (12:50 +0200)
commit7c32ae35fbf9cffb7aa3736f44dec10c944ca18e
treea1a2a0b1ef3c07979c4bfb8869f97c971580d157tree | snapshot
parentf0654ba94e33699b295ce4f3dc73094db6209035commit | diff
ALSA: seq: Cover unsubscribe_port() in list_mutex

The call of unsubscribe_port() which manages the group count and
module refcount from delete_and_unsubscribe_port() looks racy; it's
not covered by the group list lock, and it's likely a cause of the
reported unbalance at port deletion.  Let's move the call inside the
group list_mutex to plug the hole.

Reported-by: syzbot+e4c8abb920efa77bace9@syzkaller.appspotmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/seq_ports.c diff | blob | history
John Crispins staging tree