tools lib traceevent: Zero should not be considered "not found" in eval_flag()
authorSteven Rostedt <rostedt@goodmis.org>
Tue, 24 Mar 2015 18:58:13 +0000 (14:58 -0400)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 26 Mar 2015 13:52:29 +0000 (10:52 -0300)
commit7c27f78a297b54c3c2f5075cb15d33431b7f6333
tree20f626ea02fb0590a0946243008f069993bc72d2
parent6ebad5c101de0d43dafc9aff88bad45819f10470
tools lib traceevent: Zero should not be considered "not found" in eval_flag()

Guilherme Cox found that:

 There is, however, a potential bug if there is an item with code zero
 that is not the first one in the symbol list, since eval_flag(..)
 returns 0 when it doesn't find anything.

That is, if you have the following enums:

enum {
  FOO_START = 0,
  FOO_GO    = 1,
  FOO_END   = 2
}

and then have:

  __print_symbolic(foo, FOO_GO, "go", FOO_START, "start",
        FOO_END, "end")

If none of the enums are known to pevent, then eval_flag() will return
zero, and it will match it to the first item in the list, which would be
FOO_GO, which is not zero.

Luckily, in most cases, the first element would be zero, and the parsing
would match out of sheer luck.

Reported-by: Guilherme Cox <cox@computer.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/20150324145813.0bfe95ba@gandalf.local.home
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/lib/traceevent/event-parse.c