bpf: sockmap: Only check ULP for TCP sockets
authorLorenz Bauer <lmb@cloudflare.com>
Mon, 9 Mar 2020 11:12:32 +0000 (11:12 +0000)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 9 Mar 2020 21:34:58 +0000 (22:34 +0100)
commit7b70973d7edb2f005511102d5a2e0116464a46a1
treeef6bdfbf69c5c495f1f1878eaf5000da0c0afa45
parent3e7c67d90e3ed2f34fce42699f11b150dd1d3999
bpf: sockmap: Only check ULP for TCP sockets

The sock map code checks that a socket does not have an active upper
layer protocol before inserting it into the map. This requires casting
via inet_csk, which isn't valid for UDP sockets.

Guard checks for ULP by checking inet_sk(sk)->is_icsk first.

Signed-off-by: Lorenz Bauer <lmb@cloudflare.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20200309111243.6982-2-lmb@cloudflare.com
include/linux/skmsg.h
include/net/inet_connection_sock.h
net/core/sock_map.c
net/ipv4/tcp_ulp.c