netfilter: nf_ct_sip: default to NF_ACCEPT in sip_help_tcp()
authorSimon Horman <horms@verge.net.au>
Tue, 21 Sep 2010 21:17:30 +0000 (21:17 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 22 Sep 2010 20:13:32 +0000 (13:13 -0700)
commit7874896a26624214bd7c05eeba7c8ab01548b1b5
tree15e62e0eb2c2a1ac911ae6a6ccb5806d0aa0c2a9
parentd485d500cf6b13a33bc7a6c09091deea7ea603ca
netfilter: nf_ct_sip: default to NF_ACCEPT in sip_help_tcp()

I initially noticed this because of the compiler warning below, but it
does seem to be a valid concern in the case where ct_sip_get_header()
returns 0 in the first iteration of the while loop.

net/netfilter/nf_conntrack_sip.c: In function 'sip_help_tcp':
net/netfilter/nf_conntrack_sip.c:1379: warning: 'ret' may be used uninitialized in this function

Signed-off-by: Simon Horman <horms@verge.net.au>
[Patrick: changed NF_DROP to NF_ACCEPT]
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netfilter/nf_conntrack_sip.c