drm/i915/gt: Take responsibility for engine->release as the last step
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 7 Jan 2020 14:31:18 +0000 (14:31 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 7 Jan 2020 15:53:26 +0000 (15:53 +0000)
commit7807a76b00d3d656c666a6042e15cff0c890eb92
tree90d0f7e53ca2955bd25572d404b75f94e12d4a68
parent05a8e45136ca7f8785363698a8bf3748cc5ec8b8
drm/i915/gt: Take responsibility for engine->release as the last step

In order to avoid a double cleanup on error, take ownership of
engine->release past the point of no [error] return.

Reported-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Fixes: e26b6d434147 ("drm/i915/gt: Pull GT initialisation under intel_gt_init()")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Tested-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200107143118.3288995-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/intel_lrc.c
drivers/gpu/drm/i915/gt/intel_ring_submission.c