ASoC: topology: Prevent use-after-free in snd_soc_get_pcm_runtime()
authorDragos Tarcatu <dragos_tarcatu@mentor.com>
Wed, 18 Dec 2019 00:05:18 +0000 (18:05 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 18 Dec 2019 20:00:05 +0000 (20:00 +0000)
commit72b46612d06b83851e2e4f7b538a0bbeb69c10de
treecb29cf5b0450bda793a3a3a3ede5956bad2f11b1
parentfb522dbb4531c14193115a09905c6c31b37dbfc5
ASoC: topology: Prevent use-after-free in snd_soc_get_pcm_runtime()

remove_link() is currently calling snd_soc_remove_pcm_runtime() after
it has already freed the memory for the link name. But this is later
read from snd_soc_get_pcm_runtime() causing a KASAN use-after-free
warning. Reorder the cleanups to fix this issue.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Dragos Tarcatu <dragos_tarcatu@mentor.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/20191218000518.5830-4-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-topology.c