audit: Remove condition which always evaluates to false
authorPranith Kumar <bobby.prani@gmail.com>
Wed, 11 Mar 2015 18:08:19 +0000 (14:08 -0400)
committerPaul Moore <pmoore@redhat.com>
Fri, 13 Mar 2015 21:32:52 +0000 (17:32 -0400)
commit724e7bfcc566375158219c1454b4b6fc416b2c4a
tree2a2c820d252b3f4821279e2d5a2dc884e776c1d8
parent5b28255278dd7e594c8dde317c2498b7dcbf900d
audit: Remove condition which always evaluates to false

After commit 3e1d0bb6224f019893d1c498cc3327559d183674 ("audit: Convert int limit
uses to u32"), by converting an int to u32, few conditions will always evaluate
to false.

These warnings were emitted during compilation:

kernel/audit.c: In function ‘audit_set_enabled’:
kernel/audit.c:347:2: warning: comparison of unsigned expression < 0 is always
false [-Wtype-limits]
  if (state < AUDIT_OFF || state > AUDIT_LOCKED)
  ^
  kernel/audit.c: In function ‘audit_receive_msg’:
  kernel/audit.c:880:9: warning: comparison of unsigned expression < 0 is
  always false [-Wtype-limits]
      if (s.backlog_wait_time < 0 ||

The following patch removes those unnecessary conditions.

Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Signed-off-by: Paul Moore <pmoore@redhat.com>
kernel/audit.c