tcp: Protect accesses to .ts_recent_stamp with {READ,WRITE}_ONCE()
authorGuillaume Nault <gnault@redhat.com>
Fri, 6 Dec 2019 11:38:49 +0000 (12:38 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Dec 2019 05:05:14 +0000 (21:05 -0800)
commit721c8dafad26ccfa90ff659ee19755e3377b829d
tree725d07517fb3ffada269bee3a5c69861c6a831c8
parentcb44a08f8647fd2e8db5cc9ac27cd8355fa392d8
tcp: Protect accesses to .ts_recent_stamp with {READ,WRITE}_ONCE()

Syncookies borrow the ->rx_opt.ts_recent_stamp field to store the
timestamp of the last synflood. Protect them with READ_ONCE() and
WRITE_ONCE() since reads and writes aren't serialised.

Use of .rx_opt.ts_recent_stamp for storing the synflood timestamp was
introduced by a0f82f64e269 ("syncookies: remove last_synq_overflow from
struct tcp_sock"). But unprotected accesses were already there when
timestamp was stored in .last_synq_overflow.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/tcp.h