rtw88: avoid holding mutex for cancel_delayed_work_sync()
authorYan-Hsuan Chuang <yhchuang@realtek.com>
Wed, 5 Feb 2020 07:08:56 +0000 (15:08 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 12 Feb 2020 16:18:28 +0000 (18:18 +0200)
commit6eab0ba99bc2c8659ee310bbc614374ebf769ff1
treed4b81ce5f77c738c8b5acf026395c40d53e1d6c0
parent398b9bdab2c351c4386a4c060e5922c47ebde691
rtw88: avoid holding mutex for cancel_delayed_work_sync()

Driver could possibly be dead-locked while canceling works with
*_sync() with mutex lock held. Those cancel_delayed_work_sync()
functions will wait until the work is done, but if we hold the
lock, they will never acquire the lock.

To prevent this, simply release the lock and acquire again after
the works have been canceled. And to avoid the works being queued
again, check if the device is at RTW_FLAG_RUNNING state, otherwise
just return and do nothing.

Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtw88/coex.c
drivers/net/wireless/realtek/rtw88/fw.c
drivers/net/wireless/realtek/rtw88/main.c