perf symbols: Improve debug image search when loading symbols
authorDave Martin <dave.martin@linaro.org>
Fri, 30 Jul 2010 12:50:09 +0000 (09:50 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 30 Jul 2010 12:54:49 +0000 (09:54 -0300)
commit6da80ce8c43ddda153208cbb46b75290cf566fac
tree6a242c17ccbfacb237c4552a22593bd67b786b1b
parent8b1389ef93b36621c6acdeb623bd85aee3c405c9
perf symbols: Improve debug image search when loading symbols

Changes:
* Simplification of the main search loop on dso__load()
* Replace the search with a 2-pass search:
* First, try to find an image with a proper symtab.
* Second, repeat the search, accepting dynsym.

A second scan should only ever happen when needed debug images are
missing from the buildid cache or stale, i.e., when the cache is out of
sync.

Currently, the second scan also happens when using separated debug
images, since the caching logic doesn't currently know how to cache
those.  Improvements to the cache behaviour ought to solve that.

Signed-off-by: Dave Martin <dave.martin@linaro.org>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/symbol.c