drivers/atm: Correct redundant test
authorJulia Lawall <julia@diku.dk>
Mon, 27 Jul 2009 18:38:52 +0000 (11:38 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Jul 2009 18:38:52 +0000 (11:38 -0700)
commit6cf5767c7107c606644503f3e95bc1855386a70f
treec4aa30d4b43668fbbb9114b07909028bc61ef528
parenta44a4a006b860476881ec0098c36584036e1cb91
drivers/atm: Correct redundant test

str has already been tested.  It seems that this test should be on the
recently returned value snr.

A simplified version of the semantic match that finds this problem is as
follows: (http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
expression E;
@@

if (x == NULL || ...) { ... when forall
   return ...; }
... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
(
*x == NULL
|
*x != NULL
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/solos-pci.c