fs/proc: fix potential unregister_sysctl_table hang
authorFrancesco Ruggeri <fruggeri@aristanetworks.com>
Thu, 13 Sep 2012 22:03:37 +0000 (15:03 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 17 Sep 2012 17:32:03 +0000 (10:32 -0700)
commit6bf6104573482570f7103d3e5ddf9574db43a363
tree4aa02983bfffbe0d623c0163822354b48693eca0
parent5698bd757d55b1bb87edd1a9744ab09c142abfc2
fs/proc: fix potential unregister_sysctl_table hang

The unregister_sysctl_table() function hangs if all references to its
ctl_table_header structure are not dropped.

This can happen sometimes because of a leak in proc_sys_lookup():
proc_sys_lookup() gets a reference to the table via lookup_entry(), but
it does not release it when a subsequent call to sysctl_follow_link()
fails.

This patch fixes this leak by making sure the reference is always
dropped on return.

See also commit 076c3eed2c31 ("sysctl: Rewrite proc_sys_lookup
introducing find_entry and lookup_entry") which reorganized this code in
3.4.

Tested in Linux 3.4.4.

Signed-off-by: Francesco Ruggeri <fruggeri@aristanetworks.com>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/proc/proc_sysctl.c