V4L/DVB: drivers/media/video/em28xx: Remove potential NULL dereference
authorJulia Lawall <julia@diku.dk>
Fri, 27 Aug 2010 05:57:18 +0000 (02:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 21 Oct 2010 03:04:53 +0000 (01:04 -0200)
commit6b81bef8cde141d8d8172a35633af27e17cf487a
treeacf25b15739555f54828e6a1f7cb9197ca908b32
parentd7ef485daa657456cad4994873148377b3561b8b
V4L/DVB: drivers/media/video/em28xx: Remove potential NULL dereference

If the NULL test is necessary, the initialization involving a dereference of
the tested value should be moved after the NULL test.

The sematic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/em28xx/em28xx-video.c