usb, signal, security: only pass the cred, not the secid, to kill_pid_info_as_cred...
authorStephen Smalley <sds@tycho.nsa.gov>
Fri, 8 Sep 2017 16:40:01 +0000 (12:40 -0400)
committerJames Morris <james.morris@microsoft.com>
Tue, 6 Mar 2018 22:05:53 +0000 (09:05 +1100)
commit6b4f3d01052a479c7ebbe99d52a663558dc1be2a
tree430c1d7c7be50abb1fe71f88426a4376d37de3ab
parenta02633e9b13dcb9b1a656b08f81bc8ba2d4d2294
usb, signal, security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

commit d178bc3a708f39cbfefc3fab37032d3f2511b4ec ("user namespace: usb:
 make usb urbs user namespace aware (v2)") changed kill_pid_info_as_uid
to kill_pid_info_as_cred, saving and passing a cred structure instead of
uids.  Since the secid can be obtained from the cred, drop the secid fields
from the usb_dev_state and async structures, and drop the secid argument to
kill_pid_info_as_cred.  Replace the secid argument to security_task_kill
with the cred.  Update SELinux, Smack, and AppArmor to use the cred, which
avoids the need for Smack and AppArmor to use a secid at all in this hook.
Further changes to Smack might still be required to take full advantage of
this change, since it should now be possible to perform capability
checking based on the supplied cred.  The changes to Smack and AppArmor
have only been compile-tested.

Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
Acked-by: Paul Moore <paul@paul-moore.com>
Acked-by: Casey Schaufler <casey@schaufler-ca.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: John Johansen <john.johansen@canonical.com>
Signed-off-by: James Morris <james.morris@microsoft.com>
drivers/usb/core/devio.c
include/linux/lsm_hooks.h
include/linux/sched/signal.h
include/linux/security.h
kernel/signal.c
security/apparmor/lsm.c
security/security.c
security/selinux/hooks.c
security/smack/smack_lsm.c