libahci: fix result_tf handling after an ATA PIO data-in command
authorTejun Heo <tj@kernel.org>
Fri, 15 Oct 2010 09:00:08 +0000 (11:00 +0200)
committerJeff Garzik <jgarzik@redhat.com>
Fri, 22 Oct 2010 01:17:00 +0000 (21:17 -0400)
commit6ad601955315b010a117306b994f2204fae85fdc
treed10eadcbb064c463a413823b9cccd018ae1a94e8
parentf7a437dda2b5c104a897405cbff678aa1eb37897
libahci: fix result_tf handling after an ATA PIO data-in command

ATA devices don't send D2H Reg FIS after an successful ATA PIO data-in
command.  The host is supposed to take the TF and E_Status of the
preceding PIO Setup FIS.  Update ahci_qc_fill_rtf() such that it takes
TF + E_Status from PIO Setup FIS after a successful ATA PIO data-in
command.

Without this patch, result_tf for such a command is filled with the
content of the previous D2H Reg FIS which belongs to a previous
command, which can make the command incorrectly seen as failed.

* Patch updated to grab the whole TF + E_Status from PIO Setup FIS
  instead of just E_Status as suggested by Robert Hancock.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Mark Lord <kernel@teksavvy.com>
Cc: Robert Hancock <hancockrwd@gmail.com>
Cc: stable@kernel.org
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/ahci.h
drivers/ata/libahci.c