ovl: Fix info leak in ovl_lookup_temp()
authorRichard Weinberger <richard@nod.at>
Fri, 16 Sep 2016 09:45:24 +0000 (11:45 +0200)
committerMiklos Szeredi <mszeredi@redhat.com>
Wed, 21 Sep 2016 14:37:07 +0000 (16:37 +0200)
commit6a45b3628ce4dcf7498b39c87d475bab6e2a9b24
treefb203edbc99e09b1c34be42f203704a651530ddf
parent8eac98b8beb4711c4ab61822cac077fd6660e820
ovl: Fix info leak in ovl_lookup_temp()

The function uses the memory address of a struct dentry as unique id.
While the address-based directory entry is only visible to root it is IMHO
still worth fixing since the temporary name does not have to be a kernel
address.  It can be any unique number.  Replace it by an atomic integer
which is allowed to wrap around.

Signed-off-by: Richard Weinberger <richard@nod.at>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Cc: <stable@vger.kernel.org> # v3.18+
Fixes: e9be9d5e76e3 ("overlay filesystem")
fs/overlayfs/dir.c