projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1ae80cf) | patch
bpf: Fix dev pointer dereference from sk_skb
authorJoe Stringer <joe@wand.net.nz>
Fri, 12 Oct 2018 21:50:53 +0000 (14:50 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Sun, 14 Oct 2018 06:03:08 +0000 (23:03 -0700)
commit67e89ac32828a29adc74e5c9bd59bd70943466f0
treed89350111e7bb1c3073d4e1a67d4a8d55735207atree | snapshot
parent1ae80cf31938c8f77c37a29bbe29e7f1cd492be8commit | diff
bpf: Fix dev pointer dereference from sk_skb

Dan Carpenter reports:

The patch 6acc9b432e67: "bpf: Add helper to retrieve socket in BPF"
from Oct 2, 2018, leads to the following Smatch complaint:

    net/core/filter.c:4893 bpf_sk_lookup()
    error: we previously assumed 'skb->dev' could be null (see line 4885)

Fix this issue by checking skb->dev before using it.

Signed-off-by: Joe Stringer <joe@wand.net.nz>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
net/core/filter.c diff | blob | history
John Crispins staging tree