default_postinst() fix wrong call of group_add
authorJohn Crispin <john@openwrt.org>
Wed, 15 Oct 2014 17:55:13 +0000 (17:55 +0000)
committerJohn Crispin <john@openwrt.org>
Wed, 15 Oct 2014 17:55:13 +0000 (17:55 +0000)
commit666659fb3159412915f828ff10c1d88673d4ef71
tree7c6be8682c7bb761ab9063f5b500981cdec96f76
parent579b0d9c5b3f0950fe69b92310af187cb8a6cd0b
default_postinst() fix wrong call of group_add

[base-files] default_postinst() fix wrong call of group_add
after 12bae65d07d29854204715cebc1ef1eae237fd9b group_add is
always called. shell scripting can be tricky...

wrong call:
[ -n "$gid" ] && group_exists $name || group_add $name $gid

this leads to a call of 'group_add' when $gid is emtpy, proof:

root@box:~ functionA() { echo A; }
root@box:~ functionB() { echo B; }
root@box:~ VAR=
root@box:~ [ -n "$VAR" ] && functionA || functionB
B
root@box:~ # functionB was called, but VAR is not filled
root@box:~ VAR=filled
root@box:~ [ -n "$VAR" ] && functionA || functionB
A

Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>
SVN-Revision: 42926
package/base-files/files/lib/functions.sh