sfc: fix dereference of table before it is null checked
authorColin Ian King <colin.king@canonical.com>
Tue, 12 May 2020 17:13:55 +0000 (18:13 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 May 2020 22:20:00 +0000 (15:20 -0700)
commit6545be82807cc01712411321730656ad8ad30474
tree285f4c9509d545824db78d943ccf072c7853e92d
parent6cb7576710aea4dfd11449b4f514a03cd9f03505
sfc: fix dereference of table before it is null checked

Currently pointer table is being dereferenced on a null check of
table->must_restore_filters before it is being null checked, leading
to a potential null pointer dereference issue.  Fix this by null
checking table before dereferencing it when checking for a null
table->must_restore_filters.

Addresses-Coverity: ("Dereference before null check")
Fixes: e4fe938cff04 ("sfc: move 'must restore' flags out of ef10-specific nic_data")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/mcdi_filters.c