nfc: nci: Potential off by one in ->pipes[] array
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 3 Apr 2019 07:13:51 +0000 (10:13 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 6 Apr 2019 22:05:07 +0000 (15:05 -0700)
commit6491d698396fd5da4941980a35ca7c162a672016
tree808896ceb6b2639bf7d00c8d086000b13abefabd
parentd7ee81ad09f072eab1681877fc71ec05f9c1ae92
nfc: nci: Potential off by one in ->pipes[] array

This is similar to commit e285d5bfb7e9 ("NFC: Fix the number of pipes")
where we changed NFC_HCI_MAX_PIPES from 127 to 128.

As the comment next to the define explains, the pipe identifier is 7
bits long.  The highest possible pipe is 127, but the number of possible
pipes is 128.  As the code is now, then there is potential for an
out of bounds array access:

    net/nfc/nci/hci.c:297 nci_hci_cmd_received() warn: array off by one?
    'ndev->hci_dev->pipes[pipe]' '0-127 == 127'

Fixes: 11f54f228643 ("NFC: nci: Add HCI over NCI protocol support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/nfc/nci_core.h