net_sched: add max len check for TCA_KIND
authorCong Wang <xiyou.wangcong@gmail.com>
Wed, 18 Sep 2019 23:24:12 +0000 (16:24 -0700)
committerJakub Kicinski <jakub.kicinski@netronome.com>
Sun, 22 Sep 2019 02:18:51 +0000 (19:18 -0700)
commit62794fc4fbf52f2209dc094ea255eaef760e7d01
tree86fa0f9dd7438975277443166f794ad3e84be5c4
parentb0e1ee435aba68c4080e3cb67adf6573aa5bcc6d
net_sched: add max len check for TCA_KIND

The TCA_KIND attribute is of NLA_STRING which does not check
the NUL char. KMSAN reported an uninit-value of TCA_KIND which
is likely caused by the lack of NUL.

Change it to NLA_NUL_STRING and add a max len too.

Fixes: 8b4c3cdd9dd8 ("net: sched: Add policy validation for tc attributes")
Reported-and-tested-by: syzbot+618aacd49e8c8b8486bd@syzkaller.appspotmail.com
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
net/sched/sch_api.c