sd: fix uninitialized variable access in error handling
authorArnd Bergmann <arnd@arndb.de>
Fri, 21 Oct 2016 15:32:24 +0000 (17:32 +0200)
committerJens Axboe <axboe@fb.com>
Tue, 25 Oct 2016 02:52:23 +0000 (20:52 -0600)
commit5f2808ff1582202175d3908973eb9e05a5e6625d
treeafb8b61be61b76362121cfc18502821d96264325
parent3c4da75814c4b8871116940eb32d3a5243026918
sd: fix uninitialized variable access in error handling

If sd_zbc_report_zones fails, the check for 'zone_blocks == 0'
later in the function accesses uninitialized data:

drivers/scsi/sd_zbc.c: In function ‘sd_zbc_read_zones’:
drivers/scsi/sd_zbc.c:520:7: error: ‘zone_blocks’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

This sets it to zero, which has the desired effect of leaving
the sd_zbc_read_zones successfully with sdkp->zone_blocks = 0.

Fixes: 89d947561077 ("sd: Implement support for ZBC devices")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Shaun Tancheff <shaun.tancheff@seagate.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/scsi/sd_zbc.c