arm64: module: don't BUG when exceeding preallocated PLT count
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Tue, 6 Mar 2018 17:15:31 +0000 (17:15 +0000)
committerWill Deacon <will.deacon@arm.com>
Thu, 8 Mar 2018 13:49:26 +0000 (13:49 +0000)
commit5e8307b9c6f40526f290663e5a4de0f78bb0446a
tree405c3d4fbb2083f6141061faa5b8acd0cf5b7331
parente03e61c3173c1079058920210ab40c458a0e0899
arm64: module: don't BUG when exceeding preallocated PLT count

When PLTs are emitted at relocation time, we really should not exceed
the number that we counted when parsing the relocation tables, and so
currently, we BUG() on this condition. However, even though this is a
clear bug in this particular piece of code, we can easily recover by
failing to load the module.

So instead, return 0 from module_emit_plt_entry() if this condition
occurs, which is not a valid kernel address, and can hence serve as
a flag value that makes the relocation routine bail out.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/kernel/module-plts.c
arch/arm64/kernel/module.c