KVM: x86: Fix single-step debugging
authorAlexander Popov <alex.popov@linux.com>
Mon, 21 Jan 2019 12:48:40 +0000 (15:48 +0300)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 25 Jan 2019 17:52:53 +0000 (18:52 +0100)
commit5cc244a20b86090c087073c124284381cdf47234
tree8ddcf6eda5a72b84c8968f7b41ab02ef5b35bf1c
parent9699f970de84292a766709029e5135ea0b6c9aa9
KVM: x86: Fix single-step debugging

The single-step debugging of KVM guests on x86 is broken: if we run
gdb 'stepi' command at the breakpoint when the guest interrupts are
enabled, RIP always jumps to native_apic_mem_write(). Then other
nasty effects follow.

Long investigation showed that on Jun 7, 2017 the
commit c8401dda2f0a00cd25c0 ("KVM: x86: fix singlestepping over syscall")
introduced the kvm_run.debug corruption: kvm_vcpu_do_singlestep() can
be called without X86_EFLAGS_TF set.

Let's fix it. Please consider that for -stable.

Signed-off-by: Alexander Popov <alex.popov@linux.com>
Cc: stable@vger.kernel.org
Fixes: c8401dda2f0a00cd25c0 ("KVM: x86: fix singlestepping over syscall")
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/x86.c