netfilter: nf_conntrack: fix confirmation race condition
authorPatrick McHardy <kaber@trash.net>
Mon, 22 Jun 2009 12:14:16 +0000 (14:14 +0200)
committerPatrick McHardy <kaber@trash.net>
Mon, 22 Jun 2009 12:14:16 +0000 (14:14 +0200)
commit5c8ec910e789a92229978d8fd1fce7b62e8ac711
treed24884793a0804bf2f96afac2248189b358b8ae2
parent8cc20198cfccd06cef705c14fd50bde603e2e306
netfilter: nf_conntrack: fix confirmation race condition

New connection tracking entries are inserted into the hash before they
are fully set up, namely the CONFIRMED bit is not set and the timer not
started yet. This can theoretically lead to a race with timer, which
would set the timeout value to a relative value, most likely already in
the past.

Perform hash insertion as the final step to fix this.

Signed-off-by: Patrick McHardy <kaber@trash.net>
net/netfilter/nf_conntrack_core.c