include/package-pack: actually call default_postinist/prerm when using APK
authorRobert Marko <robimarko@gmail.com>
Wed, 20 Nov 2024 12:51:53 +0000 (13:51 +0100)
committerRobert Marko <robimarko@gmail.com>
Thu, 21 Nov 2024 16:20:43 +0000 (17:20 +0100)
commit5b6f8353fe2af6c270a30dc8c38791cf03fd265d
tree1308eda5f43498e81229ee03e7f04f81bb1f4257
parent52519a59a859d349f154ed79e0a3d63457b6aa6a
include/package-pack: actually call default_postinist/prerm when using APK

Currently, when you install a package that ships uci-defaults scripts they
are not getting executed during package installation.

For example, if you install a new LuCI theme it ships a uci-defaults script
to add it to the UCI LuCI config so the theme is actually selectable but
that does not happen until the device is rebooted so that uci-defaults
script is actually executed.

It turns out that the recipe for post-install is the issue since it will
include contents of postinst-pkg before the call to default_postinist.
This is an issue since postinst-pkg will exit with code 0 before we ever
reach the call to default_postinist.

So, lets simply make the call to default_postinist before postinst-pkg
inclusion which is what OPKG based installation does.

The same issue affects pre-deinstall script but its not actually being hit
since we dont seem to be actually even generating prerm-pkg scripts but
lets fix this theoretical issue as well.

Fixes: #16987
Fixes: d788ab376f85 ("build: add APK package build capabilities")
Link: https://github.com/openwrt/openwrt/pull/17023
Signed-off-by: Robert Marko <robimarko@gmail.com>
include/package-pack.mk