luci-mod-network: diagnostics: remove arp-scan install placeholder
authorJo-Philipp Wich <jo@mein.io>
Mon, 11 Oct 2021 21:43:23 +0000 (23:43 +0200)
committerJo-Philipp Wich <jo@mein.io>
Mon, 11 Oct 2021 21:47:30 +0000 (23:47 +0200)
commit5ac9fd7b3b593b86dc540c9e9d9e5ec725f8cff8
treeeef28044caf3faecb70a2bc147eecf6604708d1e
parent22b74420116f561b3f024ee6c27f9adb4e97352f
luci-mod-network: diagnostics: remove arp-scan install placeholder

We do not want to advertise functionality that is not installed as it may
have been left out intentionally. Referring to "Missing" functionality
is confusing in this case. It is also not comparable to missing protocol
extension hints as those are backed by actual user configuration.

Also replace the freetext input with a dropdown of known network devices
as the hardcoded `br-lan` is not universally applicable to all setups.

In general we want to avoid hardcoding defaults which might deviate from
the system state.

Finaly drop the superfluous width annotations and add a missing space
to the RPC command declaration.

Fixes: 22b7442011 ("luci-mod-admin-full: add arp-scan to network diagnostic")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
modules/luci-mod-network/htdocs/luci-static/resources/view/network/diagnostics.js