bpf: fix null pointer dereference on pointer offload
authorColin Ian King <colin.king@canonical.com>
Tue, 13 Nov 2018 09:29:26 +0000 (09:29 +0000)
committerAlexei Starovoitov <ast@kernel.org>
Sat, 17 Nov 2018 04:48:27 +0000 (20:48 -0800)
commit592ee43faf860c1f2c0a4c11838db6fdb974bb78
treeabe6c9b8ad2e8cf99300ea96fc6e78c3bfaa6810
parent29a9c10e4110e368443f0b606d71557edee7f2cc
bpf: fix null pointer dereference on pointer offload

Pointer offload is being null checked however the following statement
dereferences the potentially null pointer offload when assigning
offload->dev_state.  Fix this by only assigning it if offload is not
null.

Detected by CoverityScan, CID#1475437 ("Dereference after null check")

Fixes: 00db12c3d141 ("bpf: call verifier_prep from its callback in struct bpf_offload_dev")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/offload.c