ASoC: Fix use-after-free at card unregistration
authorTakashi Iwai <tiwai@suse.de>
Wed, 24 May 2017 08:19:45 +0000 (10:19 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 24 May 2017 17:11:08 +0000 (18:11 +0100)
commit4efda5f2130da033aeedc5b3205569893b910de2
tree9a55c0a2d19260fe65c2fb6c2a401bc6a951abca
parent2ea659a9ef488125eb46da6eb571de5eae5c43f6
ASoC: Fix use-after-free at card unregistration

soc_cleanup_card_resources() call snd_card_free() at the last of its
procedure.  This turned out to lead to a use-after-free.
PCM runtimes have been already removed via soc_remove_pcm_runtimes(),
while it's dereferenced later in soc_pcm_free() called via
snd_card_free().

The fix is simple: just move the snd_card_free() call to the beginning
of the whole procedure.  This also gives another benefit: it
guarantees that all operations have been shut down before actually
releasing the resources, which was racy until now.

Reported-and-tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: <stable@vger.kernel.org>
sound/soc/soc-core.c