projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9e4eb1c) | patch
bna: ethtool: Avoid reading past end of buffer
authorKees Cook <keescook@chromium.org>
Fri, 5 May 2017 22:30:23 +0000 (15:30 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 May 2017 18:41:42 +0000 (14:41 -0400)
commit4dc69c1c1fff2f587f8e737e70b4a4e7565a5c94
tree5c7d102ae1944478185b324c19127b778ecbe896tree | snapshot
parent9e4eb1ce472fbf7b007f23c88ec11c37265e401ccommit | diff
bna: ethtool: Avoid reading past end of buffer

Using memcpy() from a string that is shorter than the length copied means
the destination buffer is being filled with arbitrary data from the kernel
rodata segment. Instead, use strncpy() which will fill the trailing bytes
with zeros.

This was found with the future CONFIG_FORTIFY_SOURCE feature.

Cc: Daniel Micay <danielmicay@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/brocade/bna/bnad_ethtool.c diff | blob | history
John Crispins staging tree