lan78xx: Correctly indicate invalid OTP
authorPhil Elwell <phil@raspberrypi.org>
Wed, 11 Apr 2018 09:59:17 +0000 (10:59 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Apr 2018 14:30:42 +0000 (10:30 -0400)
commit4bfc33807a9a02764bdd1e42e794b3b401240f27
tree3b52134fb2776c37657f153c275a9d264a5ba9f5
parenta43cced9a348901f9015f4730b70b69e7c41a9c9
lan78xx: Correctly indicate invalid OTP

lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP
content, but the value gets overwritten before it is returned and the
read goes ahead anyway. Make the read conditional as it should be
and preserve the error code.

Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver")
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/lan78xx.c