[PATCH] arch filter lists with < or > should not be accepted
authorEric Paris <eparis@redhat.com>
Thu, 28 Sep 2006 21:46:21 +0000 (17:46 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Wed, 4 Oct 2006 12:31:16 +0000 (08:31 -0400)
commit4b8a311bb161a3bd2ab44311f42c526b6dc76270
treea2a269d8292ebcb8020c6748dad340bf74566979
parent78b656b8bf933101b42409b4492734b23427bfc3
[PATCH] arch filter lists with < or > should not be accepted

Currently the kernel audit system represents arch's as numbers and will
gladly accept comparisons between archs using >, <, >=, <= when the only
thing that makes sense is = or !=.  I'm told that the next revision of
auditctl will do this checking but this will provide enforcement in the
kernel even for old userspace.  A simple command to show the issue would
be to run

auditctl -d entry,always -F arch>i686 -S chmod

with this patch the kernel will reject this with -EINVAL

Please comment/ack/nak as soon as possible.

-Eric

 kernel/auditfilter.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
kernel/auditfilter.c