Redefine SMC_UNK as -1 instead of 0xFFFFFFFF
authorAntonio Nino Diaz <antonio.ninodiaz@arm.com>
Wed, 14 Feb 2018 14:22:29 +0000 (14:22 +0000)
committerAntonio Nino Diaz <antonio.ninodiaz@arm.com>
Thu, 15 Feb 2018 15:04:34 +0000 (15:04 +0000)
commit4abd7fa71f3cf921aab7c2b59a838f9c5bb10bb2
treea9a3e7253bd19b61e2a1358ed892f0e1e3690bd1
parent15e5958560e9d31e7357e3a0ada2289e78758839
Redefine SMC_UNK as -1 instead of 0xFFFFFFFF

According to the SMC Calling Convention (ARM DEN0028B):

    The Unknown SMC Function Identifier is a sign-extended value of
    (-1) that is returned in R0, W0 or X0 register.

The value wasn't sign-extended because it was defined as a 32-bit
unsigned value (0xFFFFFFFF).

SMC_PREEMPT has been redefined as -2 for the same reason.

NOTE: This might be a compatibility break for some AArch64 platforms
that don't follow the previous version of the SMCCC (ARM DEN0028A)
correctly. That document specifies that only the bottom 32 bits of the
returned value must be checked. If a platform relies on the top 32 bits
of the result being 0 (so that SMC_UNK is 0x00000000FFFFFFFF), it will
have to fix its code to comply with the SMCCC.

Change-Id: I7f7b109f6b30c114fe570aa0ead3c335383cb54d
Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com>
bl31/aarch64/runtime_exceptions.S
include/lib/smcc.h