net: hns3: fix return value error while hclge_cmd_csq_clean failed
authorHuazhong Tan <tanhuazhong@huawei.com>
Wed, 1 Aug 2018 10:27:03 +0000 (18:27 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Aug 2018 17:04:25 +0000 (10:04 -0700)
commit4a62e252e888f67cb87caf36f48338889b0b8a43
tree429447acf6a3ec8a7898abe570bddff9e79e16c7
parent87f70132b08eadc19e5a78e43b814366f9929399
net: hns3: fix return value error while hclge_cmd_csq_clean failed

While cleaning the command queue, the value of the HEAD register is not
in the range of next_to_clean and next_to_use, meaning that this value
is invalid. This also means that there is a hardware error and the
hardware will trigger a reset soon. At this time we should return an
error code instead of 0, and HCLGE_STATE_CMD_DISABLE needs to be set to
prevent sending command again.

Fixes: 3ff504908f95 ("net: hns3: fix a dead loop in hclge_cmd_csq_clean")
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c