net: dsa: skb_put_padto() already frees nskb
authorFlorian Fainelli <f.fainelli@gmail.com>
Tue, 22 Aug 2017 22:12:15 +0000 (15:12 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 24 Aug 2017 03:33:49 +0000 (20:33 -0700)
commit49716679248a0bf64d8914711b2d1ea48751853e
tree75ab119854f9db3c887341aa214c0332ac945b5e
parentcd0a137acbb66208368353723f5f1480995cf1c4
net: dsa: skb_put_padto() already frees nskb

The first call of skb_put_padto() will free up the SKB on error, but we
return NULL which tells dsa_slave_xmit() that the original SKB should be
freed so this would lead to a double free here.

The second skb_put_padto() already frees the passed sk_buff reference
upon error, so calling kfree_skb() on it again is not necessary.

Detected by CoverityScan, CID#1416687 ("USE_AFTER_FREE")

Fixes: e71cb9e00922 ("net: dsa: ksz: fix skb freeing")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Woojung Huh <Woojung.Huh@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/tag_ksz.c