cpufreq: Register drivers only after CPU devices have been registered
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 14 Nov 2019 03:36:17 +0000 (09:06 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 14 Nov 2019 08:37:14 +0000 (09:37 +0100)
commit46770be0cf94149ca48be87719bda1d951066644
tree4551c1beefbe279df52867cb6eaee015f94748b8
parentd9f7aef83e007ce2137fcd5f3b8036565d639dee
cpufreq: Register drivers only after CPU devices have been registered

The cpufreq core heavily depends on the availability of the struct
device for CPUs and if they aren't available at the time cpufreq driver
is registered, we will never succeed in making cpufreq work.

This happens due to following sequence of events:

- cpufreq_register_driver()
  - subsys_interface_register()
  - return 0; //successful registration of driver

... at a later point of time

- register_cpu();
  - device_register();
    - bus_probe_device();
      - sif->add_dev();
- cpufreq_add_dev();
  - get_cpu_device(); //FAILS
  - per_cpu(cpu_sys_devices, num) = &cpu->dev; //used by get_cpu_device()
  - return 0; //CPU registered successfully

Because the per-cpu variable cpu_sys_devices is set only after the CPU
device is regsitered, cpufreq will never be able to get it when
cpufreq_add_dev() is called.

This patch avoids this failure by making sure device structure of at
least CPU0 is available when the cpufreq driver is registered, else
return -EPROBE_DEFER.

Reported-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Co-developed-by: Amit Kucheria <amit.kucheria@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Tested-by: Amit Kucheria <amit.kucheria@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/cpufreq.c