ipv6: fix false-postive maybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Fri, 18 Aug 2017 11:34:22 +0000 (13:34 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 Aug 2017 17:47:21 +0000 (10:47 -0700)
commit401481e06099533892b3d8f1db498cbc480b5b24
tree026665da2ff6c6cc37229fd73418a7735c8e6a11
parent66ff5fa08b16155707eb121af0a8169345b6e747
ipv6: fix false-postive maybe-uninitialized warning

Adding a lock around one of the assignments prevents gcc from
tracking the state of the local 'fibmatch' variable, so it can no
longer prove that 'dst' is always initialized, leading to a bogus
warning:

net/ipv6/route.c: In function 'inet6_rtm_getroute':
net/ipv6/route.c:3659:2: error: 'dst' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This moves the other assignment into the same lock to shut up the
warning.

Fixes: 121622dba8da ("ipv6: route: make rtm_getroute not assume rtnl is locked")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/route.c