net/mlx5: Fix sleep while atomic in mlx5_eswitch_get_vepa
authorHuy Nguyen <huyn@mellanox.com>
Mon, 3 Feb 2020 22:32:18 +0000 (16:32 -0600)
committerSaeed Mahameed <saeedm@mellanox.com>
Wed, 19 Feb 2020 03:01:18 +0000 (19:01 -0800)
commit3d9c5e023a0dbf3e117bb416cfefd9405bf5af0c
treed02be52c9d879380ff29bafc9944c788083592ce
parent9facfdb5467382a21fc0bd4211ced26c06f28832
net/mlx5: Fix sleep while atomic in mlx5_eswitch_get_vepa

rtnl_bridge_getlink is protected by rcu lock, so mlx5_eswitch_get_vepa
cannot take mutex lock. Two possible issues can happen:
1. User at the same time change vepa mode via RTM_SETLINK command.
2. User at the same time change the switchdev mode via devlink netlink
interface.

Case 1 cannot happen because rtnl executes one message in order.
Case 2 can happen but we do not expect user to change the switchdev mode
when changing vepa. Even if a user does it, so he will read a value
which is no longer valid.

Fixes: 8da202b24913 ("net/mlx5: E-Switch, Add support for VEPA in legacy mode.")
Signed-off-by: Huy Nguyen <huyn@mellanox.com>
Reviewed-by: Mark Bloch <markb@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c